Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[mono][AOT] Enabled tests which fail to JIT compile during AOT #86581

Merged
merged 3 commits into from
May 23, 2023
Merged

[mono][AOT] Enabled tests which fail to JIT compile during AOT #86581

merged 3 commits into from
May 23, 2023

Conversation

LeVladIonescu
Copy link
Contributor

@LeVladIonescu LeVladIonescu commented May 22, 2023 •
edited
Loading

Related to #57350 and #85643

Enabled tests which fail to JIT compile during AOT
f9d2297 
Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>
@LeVladIonescu LeVladIonescu added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels May 22, 2023
@LeVladIonescu LeVladIonescu self-assigned this May 22, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 22, 2023
@LeVladIonescu
Copy link
Contributor Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LeVladIonescu LeVladIonescu marked this pull request as draft May 22, 2023 12:40
@LeVladIonescu LeVladIonescu added area-Codegen-AOT-mono and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 22, 2023
This was referenced May 22, 2023
Open
Closed
Closed
Closed
Redisabled tests
365edcc 
Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>
@LeVladIonescu
Copy link
Contributor Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Enabled 2 tests
95c7521 
Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>
@LeVladIonescu
Copy link
Contributor Author

/azp run runtime-extra-platforms

@LeVladIonescu LeVladIonescu marked this pull request as ready for review May 23, 2023 06:54
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LeVladIonescu LeVladIonescu requested review from vargaz and SamMonoRT May 23, 2023 06:54
@LeVladIonescu LeVladIonescu removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels May 23, 2023
@LeVladIonescu LeVladIonescu changed the title [DRAFT][mono][AOT] Enabled tests which fail to JIT compile during AOT [mono][AOT] Enabled tests which fail to JIT compile during AOT May 23, 2023
@LeVladIonescu LeVladIonescu requested a review from kotlarmilos May 23, 2023 06:57
@LeVladIonescu
Copy link
Contributor Author

Failures are known and unrelated

@LeVladIonescu LeVladIonescu merged commit 026f5e0 into dotnet:main May 23, 2023
@LeVladIonescu LeVladIonescu deleted the enableTests branch May 23, 2023 11:11
@ghost ghost locked as resolved and limited conversation to collaborators Jun 22, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@kotlarmilos kotlarmilos kotlarmilos approved these changes

@vargaz vargaz Awaiting requested review from vargaz

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

Assignees

@LeVladIonescu LeVladIonescu

Labels
area-Codegen-AOT-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeVladIonescu @kotlarmilos